support latest version #2
Merged
+154
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauron99
force-pushed
the
push-qpzomypwwykl
branch
from
052be20 to
776a279
Compare
twoGiants
reviewed
Jan 29, 2026
gauron99
force-pushed
the
push-qpzomypwwykl
branch
2 times, most recently
from
bf0aeeb to
0b03d6e
Compare
twoGiants
suggested changes
Jan 29, 2026
twoGiants
left a comment
twoGiants
left a comment
There was a problem hiding this comment.
Looks great! 😸 👍
I did not expect it to bring much more complexity but surprisingly it did. Well, you really never know!
I'm proposing some structural changes which streamline the run function IMHO.
Wdyt? It's not a must.
In any case I would the DEFAULT_FUNC_VERSION constant instead of the "latest" string, put it together with the other constants at the top and simplify resolveUrl if you decide to keep it.
gauron99
force-pushed
the
push-qpzomypwwykl
branch
from
0b03d6e to
2416d3b
Compare
gauron99
force-pushed
the
push-qpzomypwwykl
branch
from
2416d3b to
2e2e559
Compare
twoGiants
approved these changes
Jan 30, 2026
twoGiants
left a comment
twoGiants
left a comment
There was a problem hiding this comment.
Great job! 🥇
Looks very clean and straight forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README.md&action.yml