fix: Polars >=1.0 fixes, kindly provided by tjader in https://github.…#259
fix: Polars >=1.0 fixes, kindly provided by tjader in https://github.…#259fabianbergermann wants to merge 12 commits intofunctime-org:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
… to old solution otherwise. (cherry picked from commit 99ecd1d)
(cherry picked from commit 6e8ab0c)
…dd test for date as well as datetime for fourier terms. (cherry picked from commit e96f0ac)
… sorting sets sorted_flag anyway, and 2 set_sorted only works on single column names. (cherry picked from commit 5aca64b)
… and remove redundant set_sorted. (cherry picked from commit c74eae9)
(cherry picked from commit f0eb8a5)
(cherry picked from commit 9c7afa0)
(cherry picked from commit b0d13af)
…zyFrame, but calling collect_schema() first.
…zyFrame, but calling collect_schema() first.
fabianbergermann
force-pushed
the
fix/plugin-registry-compat
branch
from
5b9b85c to
ecb4a2a
Compare
|
Perhaps there is scope to fork this project and support the development with a fresh pypi package? |
|
Hi, Thanks for pushing the code and make it compatible with polars >= 1.0 I contacted @baggiponte and we are going to test this weekend and hopefully merge it by then. Keep posted 👍 |
|
Hello there, thanks @MathieuCayssol for the ping. Let's ship v0.9 with polars >=1 support. This review is going to take a bit of time since there's a lot to unpack. Python 3.9 support is reaching end of life this month but I think we should address this in a separate issue (although soon). Any opinions on this? Would it be too hard to decouple this PR from the 3.9 support? I see polars is still supporting py3.9. |
5 participants
…com//pull/256
NOTE: this is only a slightly updated copy from the original PR - all credits go to the original author and the original PR
Reference Issues/PRs
What does this implement/fix? Explain your changes.
This PR fixes all issues with Polars >= 1.0 caught by existing tests.
Has been tested with Polars 1.8.2.
Any other comments?
All issues found were listed in polars' upgrade guide https://docs.pola.rs/releases/upgrade/1/, so versions of polars between 1.0 and 1.8.2 should be fine.