Skip to content

Conversation

ldmi3i
Copy link
Contributor

@ldmi3i ldmi3i commented Jan 28, 2023

No description provided.

@ldmi3i ldmi3i force-pushed the master branch 2 times, most recently from 3fdc764 to 2dd4308 Compare January 28, 2023 11:39
@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Merging #28 (55f850b) into master (e9f6f53) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   90.83%   90.85%   +0.01%     
==========================================
  Files           1        1              
  Lines         480      481       +1     
  Branches      113      113              
==========================================
+ Hits          436      437       +1     
  Misses         12       12              
  Partials       32       32              
Impacted Files Coverage Δ
lib/src/embedded_cli.c 90.85% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ldmi3i ldmi3i marked this pull request as ready for review January 28, 2023 13:43
@@ -1,5 +1,6 @@

#include <catch2/catch_test_macros.hpp>
#include <stdio.h>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, removed

#include "CliMock.h"
#include "CliTestRunner.h"

#include <cstring>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gone too)

@funbiscuit funbiscuit merged commit 60df27a into funbiscuit:master Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants