Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patrick/add checkout page #12

Merged
merged 14 commits into from
Apr 1, 2020
Merged

Patrick/add checkout page #12

merged 14 commits into from
Apr 1, 2020

Conversation

patrick-fs
Copy link
Member

@patrick-fs patrick-fs commented Mar 28, 2020

This is the final PR for the first iteration of the reference app:

  • Added checkout form and related actions + reducer

@timchin

@patrick-fs patrick-fs force-pushed the patrick/add_checkout_page branch from 6ccf636 to fda6e02 Compare March 30, 2020 12:02
src/actions/cart.ts Outdated Show resolved Hide resolved
@patrick-fs
Copy link
Member Author

patrick-fs commented Mar 31, 2020

All right @timjchin your feedback has been incorporated. Major commits:

Thunks! cdccc8d

Dispatching thunk action from checkout form: 8f7c2e3

Update reducer to handle purchased products: c75a9b5

Copy link
Contributor

@timjchin timjchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

LGTM

Copy link
Member

@van-fs van-fs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrick-fs patrick-fs merged commit 43fdbd7 into master Apr 1, 2020
@patrick-fs patrick-fs deleted the patrick/add_checkout_page branch April 1, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants