Bump grpcurl dependency to v1.9.2 #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonsinth
reviewed
Nov 28, 2024
| go 1.19 | ||
| go 1.21 | ||
|
|
||
| toolchain go1.21.3 |
There was a problem hiding this comment.
is this toolchain thing actually needed? i'm a little unclear on what it does and what it means to different go versions
There was a problem hiding this comment.
I'm not sure, I can search if this is needed. But this was automatically added by go mod tidy after I simply updated the version of the grpcurl dependency.
There was a problem hiding this comment.
Ok, so it seems that we don't need this toolchain directive, because it'd be implicit by the go directive, which points to the same version, but since this is added by go mod tidy, I'm tempted to just leave it.
dragonsinth
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the version of the
grpcurldependency, which also bumps the minimum Go version to 1.21.