feat: add headers to grpcurl command #248
Conversation
| if (name !== "") { | ||
| metadataStr += ` -H "${name}: ${val}"`; | ||
| } | ||
| } |
There was a problem hiding this comment.
One thing I noticed, changing keys/values/rows in the headers doesn't trigger updateCurlCommand. I'm not sure if it's worth the level of invasiveness that would require tho. Thoughts?
Maybe we could always just force a re-render when the Raw Request tab is shown instead of the crazy stuff we're currently doing.
There was a problem hiding this comment.
For example, I noticed a bug where on first render, if you load the app (or change the selected method) and click on the raw request tab, the curl command contains an [object Object] instead of {}.
There was a problem hiding this comment.
Yes. I agree with you. For example, the updateCurlCommand func receives the entire request instead just the body. I believe this would involve a larger PR of refactoring. But for now, due to lack of time, I can't do that. Merging this PR would help people here a lot.
Grpcurl command was missing headers parameters. This PR adds it.