fix panics #4
Merged
fix panics #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stuff is getting more use, and I encountered some cases where panics happen.
inprocgrpc.Channelpanics when it sees them. So, for now, we'll silently ignore them (which, as it turns out, is whathttpgrpc.Channelwas already doing.) But I think the TODOs can be addressed soon-ish -- if/when I get client: export types implementing CallOptions for access by interceptors grpc/grpc-go#1902 and allow storing alternate transport.ServerStream implementations in context grpc/grpc-go#1904 merged to the grpc-go project.grpchan.InterceptChannel-- if there were no existing unary interceptor, the intercepted channel would panic during unary calls.