Refactor logger for message cleanup #67
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactor the logger a bit to do two things:
Allow a more generic way to provide context. Previously, important identifiers like rule ID, selector, path, etc got put into the message because that was all we had. This is problematic because when there are multiple identifiers, the message can be rather long. Another issue is that we sometimes use selector, source, and path interchangeably. Now that these are better defined from the shim PR, we can send these to FullStory as discrete name:value pairs in a custom payload.
Add an option to configure FullStory as the log appender. This was possible before, but the code was part of the window expando. Now the code is in Logger, and you'll do
window['_dlo_appender'] = 'fullstory'
. We'll still accept a customLogAppender
but code was added to also conditionally accept a string alias likefullstory
andconsole
.