Exclude debounce time from measured event handling duration #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndonze-fs
deleted the
nate/exclude-debounce-from-event-duration-telemetry
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, we're including debounce time in the measured event handling duration. By default, this debounce time is 250ms, and that debounce duration will be renewed if there are additional changes to a given rule source and path within the debounce duration. While cumulative debounce time could be interesting to measure explicitly in the future, event handling duration is intended to measure the time it takes to execute an operator pipeline -- including the final function operator call to send the transformed data to the configured rule destination. This PR narrows the scope of the event handling span to operator pipeline execution (excluding debounce time).