Skip to content

Various fixes #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 28, 2016
Merged

Various fixes #156

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9ae3316
Fix IndexOutOfBounds when downloadFile doesnt have a /
BlooJeans Nov 22, 2016
5d2376e
Fix NPE when context isn't available
BlooJeans Nov 22, 2016
fd5d25d
Fix broken window-or-global
BlooJeans Nov 22, 2016
5cc041e
Fix duplicate module Firestack
BlooJeans Nov 22, 2016
a6a445a
Add flow to storage.js
BlooJeans Nov 22, 2016
39e6eef
Better debugging logs for storage.js
BlooJeans Nov 22, 2016
7c298dd
Make firestack(__, name) param optional until it's implemented
BlooJeans Nov 22, 2016
1e92985
Fix flow definition for firestack.store()
BlooJeans Nov 22, 2016
8d55f27
Fix flow definitions for auth.js
BlooJeans Nov 22, 2016
3c9e91a
Fix flow definitions for base.js
BlooJeans Nov 22, 2016
74b27aa
Remove error if the directory already exists
BlooJeans Nov 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove error if the directory already exists
  • Loading branch information
@BlooJeans
BlooJeans committed Nov 22, 2016
commit 74b27aa65d918ae2be06b2e606e51dc9c1bc3bd0
8 changes: 1 addition & 7 deletions android/src/main/java/io/fullstack/firestack/FirestackStorage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,13 +116,7 @@ public void doInBackground(StreamDownloadTask.TaskSnapshot taskSnapshot, InputSt
String pathMinusFileName = indexOfLastSlash>0 ? localFile.substring(0, indexOfLastSlash) + "/" : "/";
String filename = indexOfLastSlash>0 ? localFile.substring(indexOfLastSlash+1) : localFile;
File fileWithJustPath = new File(pathMinusFileName);
if (!fileWithJustPath.mkdirs()) {
Log.e(TAG, "Directory not created");
WritableMap error = Arguments.createMap();
error.putString("message", "Directory not created");
callback.invoke(error);
return;
}
fileWithJustPath.mkdirs();
File fileWithFullPath = new File(pathMinusFileName, filename);
FileOutputStream output = new FileOutputStream(fileWithFullPath);
int bufferSize = 1024;
Expand Down