Repository navigation

Storage "upload" method do not save metadata on Android #141

Closed

opened

on Nov 17, 2016

Metadata is not propagated to native code.

https://github.com/fullstackreact/react-native-firestack/blob/master/android/src/main/java/io/fullstack/firestack/FirestackStorage.java#L157
Metadata map is destructured but never used.

Salakar commented on Nov 17, 2016
Salakar
on Nov 17, 2016
Collaborator
@Yarikx will sort on my branch (which is going to be merged for v3)
Yarikx commented on Nov 17, 2016
Yarikx
on Nov 17, 2016
Author
@Salakar Cool!
Salakar
added a commit that references this issue on Nov 17, 2016
fixes fullstackreact#141
5968ee1
Salakar commented on Nov 17, 2016
Salakar
on Nov 17, 2016
Collaborator
Done, on my branch.
auser commented on Nov 17, 2016
auser
on Nov 17, 2016
Contributor
Looking forward to merge this -- working on tests
Salakar commented on Nov 19, 2016
Salakar
on Nov 19, 2016
Collaborator
Closing as fixed on v3 branch.
Salakar
closed this as completed on Nov 19, 2016

to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

Labels

No labels

No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests