Skip to content

Conversation

@paabrown
Copy link
Contributor

@paabrown paabrown commented Oct 1, 2017

  1. Allow user to pass 'zIndex' and 'optimized' props to marker class. Setting the 'optimized' property to 'false' seems to help the user determine which marker displays on top using the zIndex property. See: https://stackoverflow.com/questions/11845916/google-maps-marker-zindex-doesnt-work-for-two-icon-types-symbol-and-string

1) Allow user to pass 'zIndex' and 'optimized' props to marker class. Setting the 'optimized' property to 'false' seems to help the user determine which marker displays on top using the zIndex. See: https://stackoverflow.com/questions/11845916/google-maps-marker-zindex-doesnt-work-for-two-icon-types-symbol-and-string
@auser auser merged commit 02ea901 into fullstackreact:master Oct 31, 2017
leup added a commit to leup/google-maps-react that referenced this pull request Nov 27, 2017
@blainegarrett
Copy link
Contributor

I'm just making my way around the lib, but it seems like maybe this merge caused a "conflict" in the dist package?
https://github.com/blainegarrett/google-maps-react/blame/master/dist/components/Marker.js

I'm seeing the following in my package which is causing syntax errors:

var _props = this.props,
  ...    
  title = _props.title,
  animation = _props.animation;
  optimized = _props.optimized,
  zIndex = _props.zIndex;

@paabrown
Copy link
Contributor Author

You're correct - this should be fixed

auser added a commit that referenced this pull request Mar 11, 2018
Revert change from PR #126 to fix (again) #110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants