fix object extension #293
Open
fix object extension #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubhruby
commented
Jul 10, 2024
| function _extend(origin: object, add: object): object { | ||
| const typedOrigin = { ...origin } as { [key: string]: unknown }; | ||
| function _extend(origin: object, add: object): void { | ||
| const typedOrigin = origin as {[key: string]: unknown}; |
There was a problem hiding this comment.
It has to be exactly the same object. If it is cloned, only typedOrigin is extended, not origin.
|
|
||
| function _extend(origin: object, add: object): object { | ||
| const typedOrigin = { ...origin } as { [key: string]: unknown }; | ||
| function _extend(origin: object, add: object): void { |
There was a problem hiding this comment.
Return value is not used anywhere, it only confuses what exactly is done here. Apparently this method is meant to only alter provided origin and not to return anything.
| while (i--) { | ||
| typedOrigin[keys[i]] = clonedAdd[keys[i]]; | ||
| } | ||
| return typedOrigin; |
There was a problem hiding this comment.
not used anywhere
|
ping |
|
@terehov ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #285