Containerize GH #2
Conversation
Ctl/dev/docker-compose.yml
Outdated
| max-size: 100m | ||
| max-file: "3" | ||
| volumes: | ||
| - ../../postgres_data:/var/lib/postgresql/data |
There was a problem hiding this comment.
Lets have this go to the Ctl/dev dir (see the changes i made to docker-compose in ixctl)
There was a problem hiding this comment.
Oh also can you add it to .dockerignore file so rebuilding the container doesn`t try to grab it (can just copy the one from the ixctl repo as is)
There was a problem hiding this comment.
Thanks for the feedback, this should be fixed in the latest changes.
Ctl/dev/docker-compose.yml
Outdated
| build: | ||
| context: ../.. | ||
| dockerfile: Dockerfile | ||
| command: "runserver 0.0.0.0:${DJANGO_PORT:-8080}" |
There was a problem hiding this comment.
The internal port can always be 8000 - or at least we should give it a separate env var to override it, i think
There was a problem hiding this comment.
Also fixed in the latest changes!
Ctl/dev/docker-compose.yml
Outdated
| command: "runserver 0.0.0.0:${DJANGO_PORT:-8080}" | ||
| env_file: .env | ||
| ports: | ||
| - "${DJANGO_PORT:-8080}:8080" |
There was a problem hiding this comment.
Addressed in the latest changes!
Pipfile
Outdated
| @@ -23,8 +25,10 @@ grainy = ">=1.5.0,<2" | |||
| django-grainy = ">=1.8.0,<2" | |||
| pyyaml = "*" | |||
| pip = "*" | |||
| arouteserver = "*" | |||
There was a problem hiding this comment.
Won`t be using arouteserver in devicectl, can drop it
There was a problem hiding this comment.
Okay thanks for letting me know, I removed arouteserver from the pipfile, the pipfile.lock, and the docs
|
@egfrank that looks mostly good, some changes we`d want to make to the compose file (see comments) And the arouteserver bit was left over from when i copied from ixctl, devicectl wont be using it so can remove from pipfile and the docs please 👍 |
|
@egfrank looks good now, merged |
PR for issue #1
I had to add dependencies for fullctl, arouteserver, and postgres so I pushed up a new pipenv and pipenv.lock. Let me know if any of those are erroneous- I didn't see arouteserver in the codebase but it was in the readme so I added it.
Again, if you're having any database trouble specifically I would just wait for the postgres db to initialize and then do
Ctl/dev/compose.sh downand then
Ctl/dev/compose.sh upand see if that fixes it. Additionally, if you're having a db error that seems incorrect (like saying that the database is configured incorrectly) you can just remove the /postgres_data file and re-initialize.