Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add service for stock endpoints #38

Merged
merged 8 commits into from
May 27, 2024
Merged

Add service for stock endpoints #38

merged 8 commits into from
May 27, 2024

Conversation

saschaheinl-fft
Copy link
Contributor

Currently our SDK does not provide a service for the api/stocks endpoint. This PR adds a service with methods for

  • CRUD stocks (GET, POST, PUT, DELETE)
  • GET stock summaries
  • GET stock distribution

@arnoerpenbeck
Copy link
Collaborator

The new stock module must be exported in fft-api/index.ts

arnoerpenbeck
arnoerpenbeck requested changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@arnoerpenbeck arnoerpenbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to fix request path and param names

arnoerpenbeck
arnoerpenbeck requested changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@arnoerpenbeck arnoerpenbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some parameter names are still wrong

@saschaheinl-fft saschaheinl-fft merged commit 9f14338 into main May 27, 2024
1 check passed
@saschaheinl-fft saschaheinl-fft deleted the add-stocks-endpoints branch May 27, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwilhelmFFT nwilhelmFFT nwilhelmFFT approved these changes

@arnoerpenbeck arnoerpenbeck arnoerpenbeck approved these changes

@rbettermann rbettermann Awaiting requested review from rbettermann rbettermann is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saschaheinl-fft @arnoerpenbeck @nwilhelmFFT