Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bugs creating Certificates from URI #61

Merged
merged 9 commits into from
Nov 6, 2023
Merged

fix: bugs creating Certificates from URI #61

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
98d86a9
Fix from_uri certificates bug
fulder Nov 6, 2023
31129fa
Add test calling Certificates.from_uri
fulder Nov 6, 2023
59ed99c
Use HTTPX_CLIENT in Certificates
fulder Nov 6, 2023
c751978
Return cert pem and status code from mocked get
fulder Nov 6, 2023
48b142b
Encode pem string in test
fulder Nov 6, 2023
9e066c4
Add missing linebreak
fulder Nov 6, 2023
9066908
Fix invalid func call in from_uri helper func
fulder Nov 6, 2023
ed7971a
Fix test returning text string
fulder Nov 6, 2023
38964e8
Format
fulder Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix invalid func call in from_uri helper func
  • Loading branch information
@fulder
fulder authored Nov 6, 2023
commit 906690847f1242f36bd13f43bdac290c748cb063
2 changes: 1 addition & 1 deletion pki_tools/types/certificates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ def _from_uri(cls: T, uri: str, ttl=None) -> T:
f"Issuer URI fetch failed. Status: {ret.status_code}"
)

return cls(certificates=[x509.load_pem_x509_certificate(ret.content)])
return cls.from_pem_string(ret.text)

@property
def pem_string(self):
Expand Down
Loading