Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump the dependencies group across 1 directory with 7 updates #169

Merged
merged 3 commits into from
Aug 13, 2024
Merged

chore(deps): bump the dependencies group across 1 directory with 7 updates #169

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c145df
chore(deps): bump the dependencies group across 1 directory with 7 up…
dependabot[bot] Aug 12, 2024
6680d28
Use new revocation time in ocsp
fulder Aug 13, 2024
98f97c1
Format
fulder Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use new revocation time in ocsp
  • Loading branch information
@fulder
fulder committed Aug 13, 2024
commit 6680d285f59e5e569efc0ec4a53ce38276b2e812
2 changes: 1 addition & 1 deletion docs/examples/src/ocsp/response/load_file.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ Issuer Key Hash: |-
D9C3E4CD74C0AF517F3D2D331A0EC837DEB655A26721DA83F52E01CC60AA317A94C110B7CDEF06FC
A308A541ECC7BAFDDEFC52D8620903B6E2B1CFE3759F8B27
Response Status: SUCCESSFUL
Revocation Time: 2024-03-20 23:51:38
Revocation Time: 2024-03-20 23:51:38+00:00

2 changes: 1 addition & 1 deletion docs/examples/src/ocsp/response/load_pem.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ Issuer Key Hash: |-
D9C3E4CD74C0AF517F3D2D331A0EC837DEB655A26721DA83F52E01CC60AA317A94C110B7CDEF06FC
A308A541ECC7BAFDDEFC52D8620903B6E2B1CFE3759F8B27
Response Status: SUCCESSFUL
Revocation Time: 2024-03-20 23:51:38
Revocation Time: 2024-03-20 23:51:38+00:00

2 changes: 1 addition & 1 deletion pki_tools/ocsp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def _check_ocsp_status(

if ocsp_res.is_revoked:
log.bind(
date=str(ocsp_res._x509_obj.revocation_time),
date=str(ocsp_res._x509_obj.revocation_time_utc),
).debug("Certificate revoked")
return True
else:
Expand Down
4 changes: 2 additions & 2 deletions pki_tools/types/ocsp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,8 @@ def from_cryptography(
).error("Couldn't convert issuer key hash to hex")
raise

if crypto_ocsp_response.revocation_time is not None:
revocation_time = crypto_ocsp_response.revocation_time
if crypto_ocsp_response.revocation_time_utc is not None:
revocation_time = crypto_ocsp_response.revocation_time_utc

ret = cls(
response_status=getattr(OcspResponseStatus, response_status.name),
Expand Down