Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bugs with non RSA keys signing #128

Merged
merged 8 commits into from
Mar 23, 2024
Merged

fix: bugs with non RSA keys signing #128

merged 8 commits into from
Mar 23, 2024

Conversation

fulder
Copy link
Owner

@fulder fulder commented Mar 23, 2024 •
edited
Loading

Changes:

  • [BREAKING] OCSPResponse.sign(cert: Certificate, issuer: Certificate, algorithm: HashAlgorithm, private_key: CryptoPrivateKey) parameters changed to OCSPResponse.sign(cert: Certificate, issuer: Certificate, response_algorithm: SignatureAlgorithm, private_key: CryptoPrivateKey, signature_algorithm: Optional[SignatureAlgorithm] = None)
  • Fix bug with DSA keys dump having non string values
  • Fix bug with DSA signed OCSP Response not validated correctly against the issuer
  • Fix bugs with Certificate.verify function not working for non RSA keys
  • Make Certificate.sign function signature_algorithm parameter Optional (for ED448 and ED25519 keys)
  • Make CertificateSigningRequest.sign function signature_algorithm parameter Optional (for ED448 and ED25519 keys)
  • [BREAKING] Change CertificateRevocationList.sign algorithm parameter from HashAlgorithm to and Optional SignatureAlgorithm

@fulder fulder merged commit a7ea453 into main Mar 23, 2024
6 checks passed
@fulder fulder deleted the fix-ec-string-dict branch March 23, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fulder