Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FgBioMain is not easily extended #239

Open
nh13 opened this issue May 24, 2017 · 1 comment
Open

FgBioMain is not easily extended #239

nh13 opened this issue May 24, 2017 · 1 comment

Comments

@nh13
Copy link
Member

nh13 commented May 24, 2017

It has both FgBioCommonArgs and FgBioTool hard-wired in the makeItSo method.

@tfenne
Copy link
Member

tfenne commented Nov 10, 2017

FYI I looked at this and it's not easy (not possible?) to do without breaking backwards compatibility a little bit. I was hoping we could just add type members e.g:

class FgBioMain(...) {
  type Command <: FgBioTool
  type CommonArgs <: FgBioCommonArgs
}

that would allow subclasses to override them. But type members cannot have the necessary : ClassTag, that is needed to do all the reflection hijinks in that class. So I think the only solution is to change the declaration to:

class FgBioMain[Command <: FgBioTool : ClassTag, Args <: FgBioCommonArgs : ClassTag](..) {

but that will break any other places the class is instantiated, because it will now require the type params to be supplied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants