Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to build version 0.6.0 for Flutter versions < 3.22.0 #144

Closed
JvSomeren opened this issue May 30, 2024 · 1 comment · Fixed by #146
Closed

Unable to build version 0.6.0 for Flutter versions < 3.22.0 #144

JvSomeren opened this issue May 30, 2024 · 1 comment · Fixed by #146
Assignees
@fujidaiti
Labels
bug Something isn't working P1

Comments

@JvSomeren
Copy link

While building version 0.6.0 of smooth_sheets an error is thrown for Flutter versions lower than 3.22.0.

The throw error is as follows:
.pub-cache/hosted/pub.dev/smooth_sheets-0.6.0/lib/src/foundation/sheet_drag.dart:300:34: Error: The getter 'localPosition' isn't defined for the class 'DragEndDetails'.

It boils down to this change to Flutter itself which is only available since Flutter 3.22.0.

This error does not occur for smooth_sheets version 0.5.3 while building with Flutter version 3.19.3. Due to package constraints we are currently not yet able to upgrade to the latest Flutter version.
@fujidaiti fujidaiti self-assigned this May 30, 2024
@fujidaiti fujidaiti added bug Something isn't working P1 labels May 30, 2024
This was referenced May 30, 2024
Open
Merged
fujidaiti added a commit that referenced this issue May 30, 2024
@fujidaiti
Fix: Unable to build version 0.6.0 for Flutter versions < 3.22.0 (#146)
d044cd7 
Fixes #144.

- `SheetDragDetails` subclasses no longer implement `Drag*Details`
- Bumped to 0.7.0
- Added a migration guide
@fujidaiti
Copy link
Owner

Hi @JvSomeren,

Thank you for reporting this. The patch will be included in v0.7.0.

This was referenced Aug 31, 2024
Closed
Merged
fujidaiti added a commit that referenced this issue Aug 31, 2024
@fujidaiti
Analyze and test with both lowest and highest supported Flutter SDK v…
2e98dc0 
…ersions in CI (#235)

## Related issues (optional)

Closes #229.

## Description

The workflow file was updated to run unit tests and static analysis for
both the lowest and highest supported Flutter SDK versions. This
approach helps detect potential compatibility issues across the entire
supported SDK range. For example, issue #144 stemmed from accidentally
using newly added APIs in Flutter 3.22 that don't exist in lower
versions, while issue #233 arose due to a breaking change introduced in
Flutter 3.24.


## Summary (check all that apply)

- [ ] Modified / added code
- [ ] Modified / added tests
- [ ] Modified / added examples
- [x] Modified / added others (pubspec.yaml, workflows, etc...)
- [ ] Updated README
- [ ] Contains breaking changes
  - [ ] Created / updated migration guide
- [ ] Incremented version number
  - [ ] Updated CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fujidaiti fujidaiti

Labels
bug Something isn't working P1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Unable to build version 0.6.0 for Flutter versions < 3.22.0 fujidaiti/smooth_sheets
2 participants
@JvSomeren @fujidaiti