docs(watch): correct the three (#683) source comments (#988) - #989
Open
fujibee wants to merge 1 commit into
Open
docs(watch): correct the three (#683) source comments (#988)#989fujibee wants to merge 1 commit into
fujibee wants to merge 1 commit into
Conversation
#987 fixed the (#683) tags in tests/; the same miscitation survived in three scripts/watch.sh comments. #683 is "Per-team migration copies a global read cursor without preserving its sequence floor" -- read-cursor migration. Each of the three was compared, one at a time, against that subject; keeping the tag was an allowed outcome, but none of the three is about cursor migration: - L279 "Say when this watcher is sharing an inbox with another" -- the sharing WARNING for two unfiltered watchers on unclaimed pairs. Not migration, and not the claim-race either; no issue states this behaviour, so the tag is removed. - L550 "it only records what has already been said" -- the held-pair set that de-duplicates the departure/return announcements ("said" = announced, not read). Bookkeeping, not migration; no matching issue, so the tag is removed. - L626 "the message is gone, delivered to a stream nobody is reading" -- a STALE process consuming a message for a pair ANOTHER SESSION has claimed. That is the #983 HAZARD ("watch.sh consumes a message for a role claimed between the lock read and the fetch"). This comment sits on the FIRST actas_lock_state check; #983 is the still-open window BETWEEN that check and the later fetch, so the comment NAMES the hazard -- it does not close the issue. Retagged (#983). Comments only -- no code changes. CHANGELOG.md and the git history are left alone on purpose: cut-release.sh regenerates the changelog from Conventional-Commit subjects (a hand edit reverts at the next release), both are released history, and the squash-merge subject that carries (#683) is immutable.
fujibee
force-pushed
the
fix/988-watch-sh-683-comments
branch
from
August 25, 2026 07:20
39fb613 to
8bb01cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #988. Follow-up to #987, which corrected the
(#683)tags intests/. The same miscitation survived in threescripts/watch.shcomments — and a source comment is read by the person about to change that code, so a wrong pointer there costs more than a wrong test name.#683is "Per-team migration copies a global read cursor without preserving its sequence floor" — read-cursor migration. Each comment was checked one at a time against that subject; keeping the tag was an allowed outcome (the goal is that every remaining#683be correct, not that there be none). None of the three is about cursor migration:actas_lock_statecheck, and #983 is the still-open window BETWEEN that check and the later fetch. It names the hazard; it does not close it → retagged (#983)Comments only — no code changes.
bash -nclean, enforced-assertions at baseline. (#983 remains open; nothing here fixes it.)Why one wrong number is worth this much care
The genealogy of this single miscitation — traced by
git log -Sto the introducing commits — is the whole argument:lands in three kinds of place:
tests/tags — done (#987, landed)(#683)is in the squash-merge commit subjects, immutablescripts/comments — this PRCHANGELOG.mdL274–276, regenerated by git-cliff from those subjects (a hand edit reverts next release)Three people reached "L550 is not #683" by independent routes (the code de-dups announcements, not reads; no independent evidence it was ever judged #683; its tag descends straight from a miscited subject). The point of the asymmetry: a single wrong issue number is cheap to write and, once it rides a squash merge and a release, impossible to take back.