Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DestinationUnreachable incorrectly assumed to come from target host #1225

Closed
fujiapple852 opened this issue Jul 20, 2024 · 1 comment · Fixed by #1224
Closed

DestinationUnreachable incorrectly assumed to come from target host #1225

fujiapple852 opened this issue Jul 20, 2024 · 1 comment · Fixed by #1224
Labels
bug Something isn't working
Milestone

Comments

@fujiapple852
Copy link
Owner

Trippy currently assumes that ICMP DestinationUnreachable errors are from the target host, as can be seen from line 758 in the code below:

/// Mark the `ProbeState` at `sequence` completed as `Unreachable` and update the round
/// state.
#[instrument(skip(self))]
pub fn complete_probe_unreachable(
&mut self,
sequence: Sequence,
host: IpAddr,
received: SystemTime,
icmp_code: IcmpPacketCode,
extensions: Option<Extensions>,
) {
self.complete_probe(
sequence,
IcmpPacketType::Unreachable(icmp_code),
host,
received,
true,
extensions,
);
}

@c-git
Copy link
Collaborator

c-git commented Jul 24, 2024

This also interacts with not crashing on errors from #1238 because all nodes along the path get resolved to the local machine's host name. I should add this is still a preferred behaviour over crashing.

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Aug 12, 2024
[0.11.0] - 2024-08-11

Added

- Added NAT detection for `IPv4/udp/dublin` ([#1104](fujiapple852/trippy#1104))
- Added public API ([#1192](fujiapple852/trippy#1192))
- Added support for NAT detection (`N`) column ([#1219](fujiapple852/trippy#1219))
- Added support for last icmp packet type (`T`) column ([#1105](fujiapple852/trippy#1105))
- Added support for last icmp packet code (`C`) column ([#1109](fujiapple852/trippy#1109))
- Added support for the probe failure count (`f`) column ([#1258](fujiapple852/trippy#1258))
- Added settings dialog tab hotkeys ([#1217](fujiapple852/trippy#1217))
- Added `--dns-ttl` flag to allow refreshing the reverse DNS
  results ([#1233](fujiapple852/trippy#1233))
- Added `--generate-man` flag for generating [ROFF](https://en.wikipedia.org/wiki/Roff_(software)) man
  page ([#85](fujiapple852/trippy#85))
- Added Ubuntu PPA package ([#859](fujiapple852/trippy#859))
- Added Chocolatey package ([#572](fujiapple852/trippy#572))

Changed

- [BREAKING CHANGE] Changed initial sequence to be `33434` ([#1203](fujiapple852/trippy#1203))
- [BREAKING CHANGE] Renamed `tui-max-[samples|flows]`
  as `max-[samples|flows]` ([#1187](fujiapple852/trippy#1187))
- Separated library and binary crates ([#1141](fujiapple852/trippy#1141))
- Record `icmp` packet code ([#734](fujiapple852/trippy#734))
- Transient error handling for `IPv4` on macOS, Linux &
  Windows ([#1255](fujiapple852/trippy#1255))
- Improved error messages ([#1150](fujiapple852/trippy#1150))
- Revamp the help dialog ([#1260](fujiapple852/trippy#1260))

Fixed

- Fixed `DestinationUnreachable` incorrectly assumed to come from target
  host ([#1225](fujiapple852/trippy#1225))
- Fixed incorrect target hop calculation ([#1226](fujiapple852/trippy#1226))
- Do not conflate `AddressInUse` and `AddrNotAvailable`
  errors ([#1246](fujiapple852/trippy#1246))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants