upgrade to 0.3.4

fuermosi777 · Apr 12, 2019 · d6a4714 · d6a4714
1 parent 38334c0
commit d6a4714
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,9 +1,13 @@
+## [0.3.4] - 2019-04-12
+
+- Fixed window resizing messing up scroll bar.
+
 ## [0.3.3] - 2019-04-09
 
-### Fixed
+Fixed
 - Hanlder automatically hide too early when clicking happens
 
-### Added
+Added
 - TypeScript typings
 - `start` Prop now accept specific numbers
 - Add `setPosition` method to update the scrolling position manually
diff --git a/dist/index.d.ts b/dist/index.d.ts
@@ -49,6 +49,7 @@ export default class FreeScrollbar extends React.PureComponent<Props, State> {
     componentDidUpdate(): void;
     private handleReadyStateChange;
     private prepareScrollbar;
+    private prepareScrollbarStartPos;
     private collectInfo;
     private updateTrackVisibilities;
     private resetHandlerHider;

diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-free-scrollbar",
-  "version": "0.3.3",
+  "version": "0.3.4",
   "description": "A react module for creating customizable scroll area",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

diff --git a/src/index.tsx b/src/index.tsx
@@ -175,6 +175,7 @@ export default class FreeScrollbar extends React.PureComponent<Props, State> {
       : this.props.onScrollbarScroll;
 
   public componentDidMount() {
+    window.addEventListener('resize', this.prepareScrollbar);
     document.addEventListener('mousemove', this.handleHandlerMouseMove);
     document.addEventListener('mouseup', this.handleHandlerMouseUp);
     document.addEventListener('readystatechange', this.handleReadyStateChange);
@@ -183,6 +184,7 @@ export default class FreeScrollbar extends React.PureComponent<Props, State> {
   }
 
   public componentWillUnmount() {
+    window.removeEventListener('resize', this.prepareScrollbar);
     document.removeEventListener('mousemove', this.handleHandlerMouseMove);
     document.removeEventListener('mouseup', this.handleHandlerMouseUp);
     document.removeEventListener('readystatechange', this.handleReadyStateChange);
@@ -197,6 +199,7 @@ export default class FreeScrollbar extends React.PureComponent<Props, State> {
   private handleReadyStateChange = () => {
     if (document.readyState === 'complete') {
       this.prepareScrollbar();
+      this.prepareScrollbarStartPos();
     }
   };
 
@@ -206,7 +209,9 @@ export default class FreeScrollbar extends React.PureComponent<Props, State> {
 
     // Trigger auto hider.
     this.handlerContainerScroll();
+  };
 
+  private prepareScrollbarStartPos = () => {
     const { start } = this.props;
     if (typeof start === 'string') {
       if (start.includes('bottom')) {
@@ -219,7 +224,7 @@ export default class FreeScrollbar extends React.PureComponent<Props, State> {
       this.el.scrollTop = start.top;
       this.el.scrollLeft = start.left;
     }
-  };
+  }
 
   private collectInfo = () => {
     this.offsetWidth = this.el.offsetWidth;