-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web UI #26
Web UI #26
Conversation
I don't think anyone will accept your Pull Request, please do some research on what a good Pull Request is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contributing, and we are very glad to merge this pr. 💕💕
Before this, we have a few simple changes requests:
- Please squash commits and use a meaningful commit message.
- Move
app.py
to a newdemo
folder and addgradio
dependency inrequirements.txt
.
@AricGamma thank you, I just forked from scratch and sent another PR here #51 adding the gradio dependency as well. Closing this one. |
I wrote a simple gradio web ui to call the inference. I did my best to not modify the code as much as possible.
scripts/app.py
file that does the gradio stuffHere's what the UI looks like: https://x.com/cocktailpeanut/status/1802377545733529840
Additionally, fixed the audio issue where the generated video wouldn't have sound, and you can't upload the video to social media because the video is detected as corrupt. This was because the
write_videofile
doesn't specifyaudio_codec
and ends up using None. So by specifyingaac
the generated video has sound everywhere and can be uploaded to any website. (code here: main...peanutcocktail:hallo:main#diff-53d5d3645d0d3f299313331b6b6dec81f7f7f10028f879edab54baaed2a2a3d8R318)