Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web UI #26

Closed
Closed

Conversation

cocktailpeanut
Copy link
Contributor

@cocktailpeanut cocktailpeanut commented Jun 16, 2024

I wrote a simple gradio web ui to call the inference. I did my best to not modify the code as much as possible.

  1. Just added a scripts/app.py file that does the gradio stuff
  2. The inference.py file returns the output file path, and also prints each step in the loop (otherwise it's impossible to know how far along I am when running this over a long audio clip)

Here's what the UI looks like: https://x.com/cocktailpeanut/status/1802377545733529840

Additionally, fixed the audio issue where the generated video wouldn't have sound, and you can't upload the video to social media because the video is detected as corrupt. This was because the write_videofile doesn't specify audio_codec and ends up using None. So by specifying aac the generated video has sound everywhere and can be uploaded to any website. (code here: main...peanutcocktail:hallo:main#diff-53d5d3645d0d3f299313331b6b6dec81f7f7f10028f879edab54baaed2a2a3d8R318)

@k18coldwl
Copy link

I don't think anyone will accept your Pull Request, please do some research on what a good Pull Request is.

Copy link
Member

@AricGamma AricGamma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributing, and we are very glad to merge this pr. 💕💕

Before this, we have a few simple changes requests:

  1. Please squash commits and use a meaningful commit message.
  2. Move app.py to a new demo folder and add gradio dependency in requirements.txt.

@cocktailpeanut
Copy link
Contributor Author

@AricGamma thank you, I just forked from scratch and sent another PR here #51 adding the gradio dependency as well. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants