Backlog/monorepo refactor 2025/configuration library #611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is using omegaconf for configuration composition as well as value interpolation.
This still has some issues when trying to fully resolve the config into an object or dict. OmegaConf dies not like us to fiddle with configuration keys (deleting and recreating them) during its resolve.
We can now compose/merge specific attributes from any level.
This can be used for adding additional information for the composition and resolving step. This key will also be used for storing information gathered during composition and resolving.
The Configuration class is used for keeping related information in one place for easier access.
Merge conflicts between different configuration files are now detected and reported via logging and a special conflicts key in the resolved config.
…tory' into backlog/monorepo-refactor-2025/configuration-library
Aligning the library with other libraries such as authenticate and session so they all work in similar ways.
- pickle support - dumping to base64 encoded string
- cleaning up metadata and marked for deletion keys (WIP) - various utilities to help with specific config key discovery
This resolver can execute any command incl. arguments and fills the value with the output from stdout.
Applies to: - metadata - sources - conflicts
docstrings todo cleanup
This is now automatically registered when the Configuration class is initialized. A once decorator ensures that the method is only run once.
…repo-refactor-2025/configuration-library
dennisweil
merged commit 28da34c
into
backlog/monorepo-refactor-2025/story
1 check passed
dennisweil
deleted the
backlog/monorepo-refactor-2025/configuration-library
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves :
This PR has been tested on :
Overview
Purpose:
Scope:
Implementation Details
Approach:
Reasoning:
Changes:
Trade-offs:
Testing
Tests Added:
Manual Testing:
Testing Environment:
Notes for Reviewers
Focus Areas:
Dependencies:
Known Issues: