fix: selection export and playblast creation #601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Playblasts will now be generated with the correctly selected camera. Selection exports now work when objects are in edit mode. There's a new validator that includes a fix to set the objects to OBJECT mode.
Coverage report
This PR does not seem to contain any modification to coverable code. |
lluisCM
reviewed
Nov 26, 2024
| f'Some objects are still in EDIT mode. {[_.name for _ in mesh_objects_in_edit_mode]}' | ||
| ) | ||
| raise PluginValidationError( | ||
| message="Foobar", |
lluisCM
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playblasts will now be generated with the correctly selected camera.
Selection exports now work when objects are in edit mode. There's a new validator that includes a fix to set the objects to OBJECT mode.
This PR has been tested on :