feat: Backlog/framework loader henrik #530

henriknorin-ftrack · 2024-06-11T13:40:54Z

Resolves :

CLICKUP-
FT-
SENTRY-
ZENDESK-

I have added automatic tests where applicable.
The PR contains a description of what has been changed.
The description contains manual test instructions.
The PR contains update to the release notes.
The PR contains update to the documentation.

This PR has been tested on :

Windows.
MacOs.
Linux.

Changes

Test

…q/integrations into backlog/framework-loader

…q/integrations into backlog/framework-loader-henrik

github-actions · 2024-06-11T13:42:13Z

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
libs/framework-core/source/ftrack_framework_core/engine
__init__.py					202
Project Total

_{This report was generated by python-coverage-comment-action}

lluisCM · 2024-06-12T07:54:26Z

libs/framework-core/source/ftrack_framework_core/client/__init__.py

+            self._event_hub_thread = _EventHubThread(self._remote_session)
+
+            if not self._event_hub_thread.is_alive():
+                self.logger.debug(
+                    'Starting new hub thread for {}'.format(self)
+                )
+                self._event_hub_thread.start()
+
+                # Make sure it is shutdown
+                atexit.register(self.close)


Maybe we can try to create a remote event manager so the _EventHugThread is handled there.

projects/framework-common-extensions/dialogs/standard_loader_dialog.py

lluisCM · 2024-06-12T08:21:42Z

projects/framework-common-extensions/plugins/resolve_entity_path.py

+        if not entities and False:
+            # Mock for now
+            entities = [
+                {
+                    'entity_id': 'a66902b4-987c-4ca0-ba39-87be4798f227',
+                    'entity_type': 'Component',
+                }
+            ]


We can remove this now.

lluisCM · 2024-06-12T08:46:18Z

projects/framework-common-extensions/dialogs/standard_loader_dialog.py

+    def build_ui(self):
+        # Check entities
+        # Select the desired tool_config
+        tool_config_message = None


Approach decided on the meeting:
The dialog contains the function to filter out the tool_configs based on the compatible:file_types keys from the tool_config.

Moving logic to a is_compatible class function

projects/framework-nuke/extensions/nuke.yaml

lluisCM · 2024-06-12T10:31:25Z

projects/framework-nuke/extensions/tool-configs/nuke-image-loader.yaml

+options:
+  file_types:
+    - ".png"
+    - ".jpg"
+    - ".jpeg"
+    - ".exr"
+    - ".tif"
+    - ".tiff"
+    - ".tga"
+    - ".bmp"
+    - ".hdr"
+    - ".dpx"
+    - ".cin"
+    - ".psd"
+    - ".tx"


Replace it by compatible....

lluisCM · 2024-06-12T10:32:28Z

projects/framework-nuke/source/ftrack_framework_nuke/__init__.py

+        startup_tools.append(
+            [
+                name,
+                label,
+                run_on == "startup",
+                action,
+                dialog_name,
+                options,
+            ]
+        )


Will improve this with the separated actions, and run_tool. But that will happen on the base branch.

…ialog.py Co-authored-by: Lluis Casals Marsol <112543804+lluisFtrack@users.noreply.github.com>

Co-authored-by: Lluis Casals Marsol <112543804+lluisFtrack@users.noreply.github.com>

…ftrackhq/integrations into backlog/framework-loader-henrik

…q/integrations into backlog/framework-loader-henrik

lluisCM · 2024-06-12T12:56:42Z

projects/framework-common-extensions/dialogs/standard_loader_dialog.py

+            # Inject the entity data into the context plugin
+            if 'options' not in context_plugin:
+                context_plugin['options'] = {}
+            context_plugin['options'].update(self.dialog_options)


What if we try then to be more specific? so instead of passing the self.dialog_optins pass the self.dialog_options.get('event_data')

lluisCM · 2024-06-17T08:54:43Z

projects/framework-nuke/extensions/tool-configs/nuke-image-loader.yaml

+    options:
+      name: "Nuke image loader"


Why are we passing name inside options? Is this really needed?
Can't you put logic inside the plugin or the widget to get the name instead?

Decided to extract label from tool config name

…er-henrik'

lluisCM

Will need to be tested on the final QA

henriknorin-ftrack added 15 commits June 10, 2024 14:55

Nuke image loader

f78ff8a

Merge branch 'backlog/framework-loader' of https://github.com/ftrackh…

cb218e4

…q/integrations into backlog/framework-loader

Merge branch 'backlog/framework-loader' of https://github.com/ftrackh…

a87d933

…q/integrations into backlog/framework-loader

Nuke loader

71e3abd

Merge branch 'backlog/framework-loader' of https://github.com/ftrackh…

5a10ccd

…q/integrations into backlog/framework-loader

WIP

560a1ff

Merge branch 'backlog/framework-loader' of https://github.com/ftrackh…

493845d

…q/integrations into backlog/framework-loader

Nuke loader and lodaer dialig IP

fc1060e

Merge branch 'backlog/framework-loader' of https://github.com/ftrackh…

e4aecb7

…q/integrations into backlog/framework-loader

Nuke image loader working

5ec621d

Merge branch 'backlog/framework-loader' of https://github.com/ftrackh…

3ee45f5

…q/integrations into backlog/framework-loader

Dcc config fixes

f7c662e

Merge branch 'backlog/framework-loader' of https://github.com/ftrackh…

853f5e5

…q/integrations into backlog/framework-loader-henrik

Nuke image loader working

89503c9

May revert

1ad2b26

henriknorin-ftrack requested a review from a team as a code owner June 11, 2024 13:40

henriknorin-ftrack changed the title ~~Backlog/framework loader henrik~~ feat: Backlog/framework loader henrik Jun 11, 2024

henriknorin-ftrack changed the base branch from main to backlog/framework-loader June 11, 2024 13:42

PR cleanup

37b67f2

lluisCM suggested changes Jun 12, 2024

View reviewed changes

henriknorin-ftrack and others added 9 commits June 12, 2024 13:50

Nuke image sequence and movie loaders

e9b8339

Update projects/framework-common-extensions/dialogs/standard_loader_d…

2c91067

…ialog.py Co-authored-by: Lluis Casals Marsol <112543804+lluisFtrack@users.noreply.github.com>

Update projects/framework-common-extensions/dialogs/standard_loader_d…

39fde92

…ialog.py Co-authored-by: Lluis Casals Marsol <112543804+lluisFtrack@users.noreply.github.com>

Update projects/framework-common-extensions/dialogs/standard_loader_d…

2aae3a2

…ialog.py Co-authored-by: Lluis Casals Marsol <112543804+lluisFtrack@users.noreply.github.com>

PR cleanup

6efd9be

Update projects/framework-common-extensions/dialogs/standard_loader_d…

54e1c82

…ialog.py Co-authored-by: Lluis Casals Marsol <112543804+lluisFtrack@users.noreply.github.com>

Update projects/framework-common-extensions/dialogs/standard_loader_d…

f7316b7

…ialog.py Co-authored-by: Lluis Casals Marsol <112543804+lluisFtrack@users.noreply.github.com>

Update projects/framework-nuke/extensions/nuke.yaml

c5185f0

Co-authored-by: Lluis Casals Marsol <112543804+lluisFtrack@users.noreply.github.com>

Merge branch 'backlog/framework-loader-henrik' of https://github.com/…

1bd710a

…ftrackhq/integrations into backlog/framework-loader-henrik

henriknorin-ftrack added 3 commits June 12, 2024 14:23

Attended PR changes

90de0e3

Merge branch 'backlog/framework-loader' of https://github.com/ftrackh…

b7405ce

…q/integrations into backlog/framework-loader-henrik

Sync with changes

eb88ccb

lluisCM suggested changes Jun 17, 2024

View reviewed changes

henriknorin-ftrack added 2 commits June 18, 2024 09:58

Merged remote 'backlog/framework-loader' into 'backlog/framework-load…

abac769

…er-henrik'

Removed name option; Properly check if still images and movies exist

9aea2e6

henriknorin-ftrack requested a review from lluisCM June 18, 2024 08:43

lluisCM approved these changes Jun 18, 2024

View reviewed changes

Pass event_data to _resolve_entity_paths

109eb36

henriknorin-ftrack requested a review from lluisCM June 18, 2024 09:35

lluisCM approved these changes Jun 18, 2024

View reviewed changes

henriknorin-ftrack merged commit 721bb3c into backlog/framework-loader Jun 18, 2024

henriknorin-ftrack deleted the backlog/framework-loader-henrik branch June 18, 2024 09:37

feat: Backlog/framework loader henrik #530

feat: Backlog/framework loader henrik #530

Uh oh!

Conversation

henriknorin-ftrack commented Jun 11, 2024

Changes

Test

Uh oh!

github-actions bot commented Jun 11, 2024

Coverage report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lluisCM left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants