-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Add support for setting additional headers and strictApi #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for setting additional headers and strictApi #74
Conversation
I want to see some kind of end-user-facing documentation for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my point of view!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but have not tested it only looked at the code. Expecting someone else to test.
@@ -23,6 +23,8 @@ Construct Session instance with API credentials. | |||
:param Array [options.serverInformationValues=[]]: Optional list of server information values to retrieve. | |||
:param Object [options.eventHubOptions={}]: Options to configure event hub with. | |||
:param string [options.clientToken=null]: Client identifier included in update events caused by operations performed by this session. | |||
:param Object [options.headers]: Additional headers to send with the request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be options.additionalHeaders
?
@@ -95,11 +97,13 @@ export interface ResponseError { | |||
|
|||
export interface MutatationOptions { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MutatationOptions ? ;)
* feat: add support for setting additional headers and strictApi * docs: update documentation * updated docs
Resolves FT-1b5069d6-a6dc-11ed-8149-8a547ff3bf63
Changes
Test
ftrack-strict-api: true
is sent as header.