Skip to content

fix: Catch preflight errors on file upload #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 8, 2024
Merged

fix: Catch preflight errors on file upload #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
776b476
Catch preflight errors on js api
Feb 28, 2024
094684e
ts error fix
Feb 28, 2024
d2d939b
Throw error instead of return statement
Mar 8, 2024
fdf70fa
Add second reaction for uploader
Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1090,7 +1090,7 @@ export class Session<
},
});

uploader.start();
uploader.start().catch(reject);
});
}
}
Expand Down
9 changes: 8 additions & 1 deletion source/uploader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,14 @@ export class Uploader<TEntityTypeMap extends Record<string, any>> {
/** Initiate upload. Promise is resolved once preflight is complete and upload started. */
async start() {
logger.debug("Upload starting", this.componentId);
await this.uploadPreflight();
try {
await this.uploadPreflight();
} catch (error) {
if (this.onError) {
this.onError(error as Error);
}
throw error;
}
if (!this.uploadMetadata) {
throw new Error("Failed to get upload metadata");
}
Expand Down