fix: Single-part uploads not retried when request fails #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmycallin
approved these changes
Jun 13, 2023
gismya
deleted the
backlog/multipart-upload-in-studio/single-part-uploads-not-retried-when-failing-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves FT-6488286c-04b7-4f74-a46a-991236937e79
Changes
Single-part uploads tried to cleanup after a failed upload attempt, causing the exponential back-off to not work as expected. Moved the cleanup to after all attempts fail.
Also set the aborted flag so that an upload that is aborted using the XHR option is not retried again.
Test
Test together with https://github.com/ftrackhq/frontend/pull/714
Block the upload domain:
Attempt to upload a file < 16 MB, and verify that if you then unblock the domain again it succeeds.