-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Support multi-part uploads in JS API #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support multi-part uploads in JS API #115
Conversation
…oad-in-studio/support-multipart-uploading-in-js-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a great start. Some inconsistencies in the async syntax used, I suggest making sure async/await is used consistently.
source/uploader.ts
Outdated
2 ** retry * 100 | ||
} before retrying...` | ||
); | ||
wait(2 ** retry * 100).then(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intuitively, this feels short. Did you base this on anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've replaced this with a separate implementation in back_off.
It will wait a delay of 0.5s, then double that for each attempt up to a maximum of 64 seconds. It will attempt a maximum of 16 tries before giving up.
…oad-in-studio/support-multipart-uploading-in-js-api
…ultipart-uploading-in-js-api
…loading-in-js-api' of github.com:ftrackhq/ftrack-javascript into backlog/multipart-upload-in-studio/support-multipart-uploading-in-js-api
Resolves FT-cbc1aaec-2dcb-40a5-a298-4d85ea15851e
Changes
Test