Skip to content

feat: Allow aborting uploads using AbortSignal #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lucaas
Copy link
Contributor

@lucaas lucaas commented May 25, 2023

Resolves FT-4fe346cb-3f20-438d-9b07-d1ee95f19e33

  • I have added automatic tests where applicable
  • The PR title is suitable as a release note
  • The PR contains a description of what has been changed
  • The description contains manual test instructions

I branched this off the latest tag as I had some issues testing with the new event hub client implementation.

Changes

  • Deprecate xhr option as that is will not be compatible with multi-part uploads
  • Introduce a signal option for aborting uploads (similar to other methods)

Test

  1. Check that you agree with API
  2. Verify that tests run.

@lucaas lucaas requested a review from gismya May 25, 2023 13:05
@lucaas lucaas requested a review from a team as a code owner May 25, 2023 13:05
@lucaas lucaas requested a review from jimmycallin May 26, 2023 11:09
Copy link
Contributor

@jimmycallin jimmycallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code and tests looks good, haven't tried it but you can merge it imo once you have considered my question

@lucaas lucaas merged commit 133b5ca into main May 26, 2023
@lucaas lucaas deleted the backlog/multipart-upload-in-studio/replace-api-for-aborting-uploads-in-js-api branch May 26, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants