Skip to content

fix(test): Fix Math.random flaky test #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2023
Merged

fix(test): Fix Math.random flaky test #108

merged 1 commit into from
May 23, 2023

Conversation

gismya
Copy link
Contributor

@gismya gismya commented May 23, 2023

  • I have added automatic tests where applicable
  • The PR title is suitable as a release note
  • The PR contains a description of what has been changed
  • The description contains manual test instructions

Changes

Math.random() made a test flaky. Changed to a mock random.

Test

Make sure it runs consistently.

@gismya gismya requested a review from a team as a code owner May 23, 2023 13:01
@gismya gismya merged commit 0a140a7 into main May 23, 2023
@gismya gismya deleted the fix-flaky-test branch May 23, 2023 13:06
lucaas added a commit that referenced this pull request May 26, 2023
@lucaas
Revert "fix(test): Fix Math.random flaky test (#108)"
2ef5aaa 
This reverts commit 0a140a7.
@lucaas lucaas mentioned this pull request May 26, 2023
Merged
4 tasks
lucaas added a commit that referenced this pull request May 26, 2023
@lucaas
fix: Revert "Replace socket.io-client" (#111)
ca25de7 
* Revert "fix(test): Fix Math.random flaky test (#108)"

This reverts commit 0a140a7.

* Revert "feat: Replace socket.io-client (#99)"

This reverts commit ceb68a7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmycallin jimmycallin jimmycallin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gismya @jimmycallin