fix: TypeScript ESM compatibility fixes for moduleResolution: NodeNext #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When importing the library in TypeScript using
"moduleResolution": "NodeNext", the typings it produced were wrong due to TypeScript starting to rely on the native Node ESM module resolution implementation. You can read more about this here: https://www.typescriptlang.org/docs/handbook/esm-node.htmlIn short, we need to change all relative imports to use a
.jsfile ending.Test
Try importing this as a library using node and ts-node and make sure it behaves as expected. It's good to verify that the right bundle is imported by adding different console logs in both the umd and es build and verify that the output matches your expectations.