Skip to content

fix(typescript): type private methods as private #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2023
Merged

fix(typescript): type private methods as private #105

merged 1 commit into from
May 19, 2023

Conversation

gismya
Copy link
Contributor

@gismya gismya commented May 19, 2023

  • I have added automatic tests where applicable
  • The PR title is suitable as a release note
  • The PR contains a description of what has been changed
  • The description contains manual test instructions

Changes

Adds private modifiers to methods that should be private.

Closes #87

Test

Make sure all CI tests still work. Shouldn't have any effect on the runtime code since it's only a typescript modifier.

@gismya gismya requested a review from a team as a code owner May 19, 2023 09:18
@gismya gismya merged commit 959f1da into main May 19, 2023
@gismya gismya deleted the type-private-methods-as-private branch May 19, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmycallin jimmycallin jimmycallin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Private methods should actually be private
2 participants
@gismya @jimmycallin