Skip to content

Add github actions #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 9, 2022
Merged

Add github actions #1

merged 8 commits into from
Aug 9, 2022

Conversation

jimmycallin
Copy link
Contributor

@jimmycallin jimmycallin commented Aug 8, 2022 •
edited
Loading

Changes

  • Added github actions for testing and publishing to npm on @ftrack/api
  • Updated documentation to include how to contribute and release new versions.
  • Removing references to Bitbucket in the documentation. We should make further updates to the documentation, but I didn't want to spend too much time on it at the moment.

Test

  • Go through the actions and make sure they look ok.
  • Please read CONTRIBUTING.md and make sure the action scripts reflect this properly.

See rulebook for how I set up yarn scripts: https://yarnpkg.com/advanced/rulebook

@jimmycallin jimmycallin force-pushed the actions branch 5 times, most recently from 72aeadd to d6fe3c9 Compare August 9, 2022 08:59
@jimmycallin jimmycallin requested a review from lucaas August 9, 2022 09:53
lucaas
lucaas reviewed Aug 9, 2022
View reviewed changes
Copy link
Contributor

@lucaas lucaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Added some minor comments and questions.

lucaas
lucaas reviewed Aug 9, 2022
View reviewed changes
jimmycallin and others added 2 commits August 9, 2022 14:06
@jimmycallin @lucaas
Apply suggestions from code review
a0f89d1 
Co-authored-by: Lucas Stålner Correia <lucas.correia@ftrack.com>
@jimmycallin
set up dependency caching
e0d2cb5
lucaas
lucaas reviewed Aug 9, 2022
View reviewed changes
Copy link
Contributor

@lucaas lucaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I confused YAML line items and git diffs in my earlier suggestions.

lucaas
lucaas approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@lucaas lucaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's test the publish action by releasing a new version! 🚀

@jimmycallin jimmycallin merged commit 8541a11 into main Aug 9, 2022
@jimmycallin jimmycallin deleted the actions branch August 9, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucaas lucaas lucaas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmycallin @lucaas