Don't block test exits when opening a trace#98
Merged
Conversation
nathanl
force-pushed
the
spawn_to_open_trace
branch
from
ae6f069 to
7bc50c4
Compare
ftes
reviewed
Nov 12, 2025
Owner
ftes
left a comment
ftes
left a comment
There was a problem hiding this comment.
Looks good. Great idea! Tiny suggestion.
nathanl
changed the title
If `@tag trace: :open` is given, do not block the `on_exit/1` call until the `show-trace` program is closed. Spawn a process to open it and let `on_exit/1` finish so that the `mix test` command can finish.
nathanl
force-pushed
the
spawn_to_open_trace
branch
from
7bc50c4 to
b0b9193
Compare
Owner
|
Thanks Nathan! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
@tag trace: :openis given, do not block theon_exit/1call until theshow-traceprogram is closed. Spawn a process to open it and leton_exit/1finish so that themix testcommand can finish.