vk: include <limits.h> in vk_init.c for UINT_MAX - #456
Open
bradenleague wants to merge 1 commit into
Open
Conversation
vk_init.c references UINT_MAX but does not include <limits.h>, relying on it being pulled in transitively. When the Vulkan headers are installed (enabling VKQUAKE), the CMake build fails to compile vk_init.c with "use of undeclared identifier 'UINT_MAX'". Add the missing include. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
engine/vk/vk_init.c references UINT_MAX but does not include <limits.h>, relying on it being pulled in transitively. When the Vulkan headers are installed (so VKQUAKE is enabled), the CMake build fails to compile vk_init.c with
error: use of undeclared identifier 'UINT_MAX'(seen here at vk_init.c:4869 with Apple clang). The Makefile gl-rel target does not compile the vk backend, which is why upstream CI has not hit it. Adding#include <limits.h>fixes the build; no behavioural change.