Skip to content

Conversation

@hoffie
Copy link

@hoffie hoffie commented Jan 6, 2022

log.Warnf("error while shutting down the file system watcher: %v", fmt.Sprintf(format, args))
references "log", which the go tooling resolves to github.com/prometheus/common/log. The latter is deprecated and has been renamed to promlog in recent versions. Therefore, the build is broken when grok_exporter parts are imported by other packages which rely on newer prometheus/common versions.

I believe that prometheus/common/log was never supposed to be used as all other places use logrus.

I have therefore updated the file to use the logrus instance from the caller.

hoffie added a commit to hoffie/multilog_exporter that referenced this pull request Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant