Skip to content

Conversation

@davidgasquez
Copy link
Contributor

Hey there! Saw the installation were missing on the README.

@davidgasquez
Copy link
Contributor Author

@d70-t, any thoughts on this?

Copy link
Collaborator

@d70-t d70-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @davidgasquez, thanks for the initiative! I've been away for the last 5 weeks and just slowly catching up, thus answering only that late.

I guess the official way of installing would be to install the latest released version via pypi, thus just using the package name in the command. Your suggestion would install the current (maybe unreleased) main branch.

@d70-t
Copy link
Collaborator

d70-t commented Jun 20, 2023

I've had a look into the CI errors above. The are seemingly related to updates to common IPFS servers which had not yet been accounted for in the code. I've added a few updates to the current main. If you'd merge or rebase, the errors should go away.

davidgasquez and others added 2 commits June 21, 2023 09:39
@davidgasquez
Copy link
Contributor Author

Thanks for jumping in!

I guess the official way of installing would be to install the latest released version via pypi, thus just using the package name in the command. Your suggestion would install the current (maybe unreleased) main branch.

Agree!

I've added a few updates to the current main. If you'd merge or rebase, the errors should go away.

✔️

@d70-t
Copy link
Collaborator

d70-t commented Jun 21, 2023

Thanks for updating! 🎉

@d70-t d70-t merged commit 412c542 into fsspec:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants