Implement _cp_file for Zonal Buckets & support custom flush interval#746
Open
suni72 wants to merge 13 commits intofsspec:mainfrom
Open
Implement _cp_file for Zonal Buckets & support custom flush interval#746suni72 wants to merge 13 commits intofsspec:mainfrom
suni72 wants to merge 13 commits intofsspec:mainfrom
Conversation
suni72
force-pushed
the
zonal-fix-1
branch
7 times, most recently
from
6b68697 to
2cd21fb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #746 +/- ##
==========================================
+ Coverage 75.41% 76.06% +0.65%
==========================================
Files 19 19
Lines 2859 2879 +20
==========================================
+ Hits 2156 2190 +34
+ Misses 703 689 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
suni72
force-pushed
the
zonal-fix-1
branch
5 times, most recently
from
140e1c5 to
da12664
Compare
suni72
changed the title
Collaborator
|
/gcbrun |
1 similar comment
Collaborator
|
/gcbrun |
* Adds test coverage check in repo * Adds pytest covergae dependency * Update threshold for new code
Update grpc_client since MRD and AAOW now accept AsyncGrpcClient object
update comment in test_zb_hns_utils.py
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
ankitaluthra1
requested changes
Feb 9, 2026
| if block_size is None: | ||
| block_size = self.default_block_size | ||
| # If we are using the generic default (user didn't override it), | ||
| # switch to the Zonal-optimized default for Zonal buckets. |
Collaborator
There was a problem hiding this comment.
why do we need zonal default to be different from regional ?
Contributor
Author
There was a problem hiding this comment.
Python SDK uses 16 MB. I believe the 16 MB flush interval was chosen to maximize throughput, so we should align with that standard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes:
_cp_filelogic for Zonal buckets.aaowinitialization logic inZonalFile.python-storageSDK.python-storage.ulimitin tests to prevent "too many open files" errors.