Skip to content

Remove any references to Python 3.8 #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DimitriPapadopoulos
Copy link
Contributor

No description provided.

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review July 9, 2025 19:14
@martindurant
Copy link
Member

Indeed 3.8 is EOL, and I support dropping any mention to it. However, this PR does not drop support for it, but changes the installed python version for one of the CI checking runs - a run which is not currently invoked at all.

@martindurant
Copy link
Member

(the changelog suggests 3.8 support was dropped in code in 2025.3.2)

@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented Jul 10, 2025

Then how about removing file ci/environment-typecheck.yml? And ci/environment-py38.yml? Or all of ci?

I came across this file while grep'ping for 3.8 through the repository to solve an issue with Python 3.8 while preparing #1887. I don't even know what the ci directory is about, but the occurrence of 3.8 in it is confusing.

I wrote "Drop support" because I see this issue as a left-over from the PR that did drop support for 3.8. I will change the title.

@DimitriPapadopoulos DimitriPapadopoulos changed the title Drop support for Python 3.8 Remove any references to Python 3.8 Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants