-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error:asyncio:Unclosed connector #129
Comments
I've just hit this issue too, I think this is because Azure async clients should be used as context managers or their |
I'm not sure i have the best solution, i checked what was doing gcsfs regarding this. |
This is still broken in fs = AzureBlobFileSystem(
account_name=gen2_storage_account_name,
tenant_id=tenant_id,
client_id=gen2_client_id,
client_secret=gen2_client_secret
)
fs.ls("") Produces:
|
This still happens in import asyncio
fs = AzureBlobFileSystem(
account_name=gen2_storage_account_name,
tenant_id=tenant_id,
client_id=gen2_client_id,
client_secret=gen2_client_secret
)
fs.ls("")
asyncio.run(fs.credential.close()) # <-- this |
What happened:
When running upload/download scripts using adlfs, we get a warning on every run:
While it is just a warning, it can be scary for end-users as it seems that something went wrong.
What you expected to happen:
No warning should be raised
Minimal Complete Verifiable Example:
Anything else we need to know?:
My immediate guess is that it comes from not closing the credentials transport session per this issue: Azure/azure-sdk-for-python/issues/8990 and this PR: Azure/azure-sdk-for-python/pull/9090
If that is the source, I imagine the fix would be to call
close
on the credentials object, but I'm not sure where in the lifecycle to do that.Environment:
The text was updated successfully, but these errors were encountered: