refactor: Use Snappier library instead of Snappy.Standard #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for the PR! It looks like you've removed array pools, so GC pressure will be high, can you try returning it back for performance purpose? It looks like Snappier does support work with buffers and spans |
Lanayx
approved these changes
Jun 19, 2024
Thank you so much!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My organization has started using Snyk to detect vulnerabilities in repositories. It is complaining that Snappy.Standard, an 8 year old project, is using an ancient version of System.Net.Http with vulnerabilities.
This PR replaces the Snappy.Standard library with the more modern Snappier library.