Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update was a bit tricky, because the member ranges returned from FCS changed a bit due to work that @auduchinok did in the parser. As a result, I had to update the logic around member flag generation to
A) only apply to ranges that are members, and
B) find members that are 'within' the range of this trivia.
I tried to update the trivia range to match the range of the member, but doing that was beyond me. An example:
Sample Code:
Given this code, the range for:
19,4-19,61
,19,12-9,61
, andSynMemberDefn.Member
is19,4-19,61
So the old simple check for
trivia.range = rangeOfBindingAndRhs
would naturally never hold anymore. I'm not sure my fix is the best fix.