Indenting of record definition when internal

[cmeeren]

Online here

Input:

type RequestParser<'ctx, 'a> = internal {
  consumedFields: Set<ConsumedFieldName>
  parse: 'ctx -> Request ->  Async<Result<'a, Error list>>
  prohibited: ProhibitedRequestGetter list
}

Output:

type RequestParser<'ctx, 'a> =
  internal { consumedFields: Set<ConsumedFieldName>
             parse: 'ctx -> Request -> Async<Result<'a, Error list>>
             prohibited: ProhibitedRequestGetter list }

As mentioned in #657 I strongly dislike code that is indented to "match up".

I usually format records like at the top (input) because it's the easiest format to extend (press enter from end of last line to add new field, don't have to worry about placing cursor inside the brackets and spacing them correctly at the next line). But another alternative to the current Fantomas behaviour that does not indent the whole definition due to internal is this:

type RequestParser<'ctx, 'a> =
  internal
    { consumedFields: Set<ConsumedFieldName>
      parse: 'ctx -> Request ->  Async<Result<'a, Error list>>
      prohibited: ProhibitedRequestGetter list }

[cmeeren]

Note that this goes for the return keyword, too:

fantomas-online

Code

let f () =
  async {
    let x = 2
    return some rather long |> stuff that |> uses piping |> to' demonstrate |> the issue
  }

Result

let f () =
    async {
        let x = 2

        return some rather long
               |> stuff that
               |> uses piping
               |> to' demonstrate
               |> the issue
    }

Better (IMHO)

let f () =
    async {
        let x = 2

        return
          some rather long
          |> stuff that
          |> uses piping
          |> to' demonstrate
          |> the issue
    }

[nojaf]

@cmeeren could you create a separate issue of that one?
In AST terms, they are different constructs.

[cmeeren]

Created #1062