Swagger method names nicePascalName is not a nice name.

Unsure if bug or feature, but the generated method names (

SwaggerProvider/src/SwaggerProvider.DesignTime/OperationCompiler.fs

Line 208 in 2184d9e

let methodNameCandidate = nicePascalName <| getMethodNameCandidate op

) are fed through nicePascalName. This causes a separation between what is in the JSON schema and the function name that is generated.

E.g. "operationId":"Application_GetLatestApplicationDetails" in the JSON schema gets turned into nicePascalName "Application_GetLatestApplicationDetails" which subsequently returns ApplicationGetLatestApplicationDetails which is less ideal.

nicePascalName "Application_GetLatestApplicationDetails" = nicePascalName "ApplicationGet_LatestApplicationDetails" returns true, even though they are separate controllers and separate functions.

I would expect that the operationId in the JSON directly maps to a function in the generated results of the TP.

[sergey-tihon]

The initial idea was to generate names that will play nice for C# users, because it is generated type provider and we have no stoppers to be C# friendly,

That's why I try to avoid _ in function names, nicePascalName is reused from FSharp.Data.

How do you generate swagger schema in you case? Do you use Swashbuckle or you schema is hard-written?

During the testing agains APIs.guru schemas, i found that I could not rely on operationId for all cases

Hmm , Interesting, I generate my schema using swashbuckle (see #46 (comment)), I would like Swagger to generate static classes (Modules) for controllers, this would be similar to the C# approach (see below).

In Visual Studio 2015 if we add a C# WebAPI project (C# WebApp -> WebAPI), then right click the new WebAPI project -> Add -> REST Api Client, and enter in the JSON from our API (say http://localhost:48213/swagger/docs/v1), we actually see that the C# codegen takes the controller name and uses this as a partial class.

Edit: e.g. Application_GetLatestApplicationDetails in the schema where 'Application' is the controller and 'GetLatestApplicationDetails' is the method, the C# code seems to generate as:

namespace WebApplication1
{
    internal partial class Application : IServiceOperations<MyAPI>, IApplication
    {
...
            public async Task<HttpOperationResponse<bool>> GetLatestApplicationDetailsWithOperationResponseAsync(TestDirect input, CancellationToken cancellationToken = default(System.Threading.CancellationToken))
        {

[sergey-tihon]

This feature is implemented and released in 0.10.0-alpha7 but turned off by default.

In order to turn it on, you need to add parameter IgnoreControllerPrefix = false
For each controller will be generated separate *Client class

Sample

type GI = SwaggerProvider<"https://api.apis.guru/v2/specs/gettyimages.com/3/swagger.json", IgnoreControllerPrefix = false>

let c1 = GI.ArtistsClient()
let c2 = GI.UsageClient()