Skip to content

[repo-assist] Fix: paket remove does not remove clitool packages from paket.dependencies #4405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsyme merged 1 commit into from
Aug 30, 2026
+13 −1
Merged

[repo-assist] Fix: paket remove does not remove clitool packages from paket.dependencies #4405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Paket.Core/PaketConfigFiles/DependenciesFile.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ type DependenciesFile(fileName,groups:Map<GroupName,DependenciesGroup>, textRepr
let tryMatchPackageLine packageNamePredicate (line : string) =
let tokens = line.Split([|' '|], StringSplitOptions.RemoveEmptyEntries) |> Array.map (fun s -> s.ToLowerInvariant().Trim())
match List.ofArray tokens with
| "nuget"::packageName::_ when packageNamePredicate packageName -> Some packageName
| ("nuget" | "clitool")::packageName::_ when packageNamePredicate packageName -> Some packageName
| _ -> None

let isPackageLine name line = tryMatchPackageLine ((=) name) line |> Option.isSome
Expand Down
12 changes: 12 additions & 0 deletions tests/Paket.Tests/DependenciesFile/RemovePackageSpecs.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,18 @@ nuget Castle.Windsor ~> 3.2"""
cfg.ToString()
|> shouldEqual (normalizeLineEndings expected)

[<Test>]
let ``should remove a clitool package``() =
let config = """source http://www.nuget.org/api/v2
clitool Invoke-Build"""

let cfg = DependenciesFile.FromSource(config).Remove(Constants.MainDependencyGroup, PackageName "Invoke-Build")

let expected = "source http://www.nuget.org/api/v2"

cfg.ToString()
|> shouldEqual (normalizeLineEndings expected)

[<Test>]
let ``should not remove group if only contains remote files``() =
let config = """source http://www.nuget.org/api/v2
Expand Down
Loading