Repository navigation
[repo-assist] Fix local NuGet source not recognizing .symbols.nupkg packages - #4388
Merged
dsyme merged 1 commit intoAug 29, 2026
Conversation
Closes #1587 paket.dependency local folder sources ignored packages whose only file present was the *.symbols.nupkg variant, because both the version-listing code in NuGetLocal.fs and the shared parsePackageInfoFromFileName helper in NuGetCache.fs explicitly filtered out or failed to parse filenames ending in '.symbols.nupkg'. This strips the '.symbols' suffix before matching/parsing package name and version, so a symbol-only local feed entry resolves the same as its regular counterpart. 🤖 Generated by Repo Assist, an automated AI assistant for this repository. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
17 tasks
dsyme
marked this pull request as ready for review
August 29, 2026 09:34
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated response from Repo Assist, an automated AI assistant.
Closes #1587
Root cause
When a local NuGet folder source (
source c:/...inpaket.dependencies) contains only a symbols package (e.g.PackageName.1.2.3.symbols.nupkg), Paket failed to find/version it:getAllVersionsFromLocalPathinNuGetLocal.fsexplicitly filtered out any file ending in.symbols.nupkgbefore matching versions.parsePackageInfoFromFileNamehelper inNuGetCache.fs(used byfindLocalPackage/tryFindLocalPackageas a fallback lookup) also failed to parse.symbols.nupkgfilenames, since its regex expects a bare.nupkgsuffix.Fix
Both functions now strip a trailing
.symbolsfrom the filename before matching/parsing package name and version, so a symbols-only package in a local feed resolves identically to its normal counterpart.Trade-offs
.nupkgstill applies).Test Status
NuGetLocalSpecs.fscovering.symbols.nupkgfilenames forparsePackageInfoFromFileName.dotnet test tests/Paket.Tests/Paket.Tests.fsproj --filter "FullyQualifiedName~NuGetLocalSpecs": net9 target passed (2/2). The net461 target could not execute in this sandbox becausemonois not installed (pre-existing infrastructure limitation, unrelated to this change).Add this agentic workflow to your repo
To install this agentic workflow, run