Skip to content

Migrated to .NET 9.0.201 and F# compiler 43.9.201 #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 1, 2025
Merged

Migrated to .NET 9.0.201 and F# compiler 43.9.201 #722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
457344c
feat: remove Paket and migrate to F# 9.0.201 compatible packages
xperiandri Jun 27, 2025
31fecba
refactor: migrate to F# compiler 43.9.201
xperiandri Jun 28, 2025
041d4df
fix: new ListCons syntax construct handling
xperiandri Jun 28, 2025
105cbb8
fix: determining camel case constructor parameters
xperiandri Jun 28, 2025
e25c821
fix: cyclomatic complexity test code indentation
xperiandri Jun 28, 2025
9863cdc
fix: output parsing for `FunctionalTest` tests
xperiandri Jun 28, 2025
3e89ee5
fix(tests): write test logs into test context output
xperiandri Jun 28, 2025
0cc45e8
refactor(tests): `TestContext.Out.WriteLine(sprintf` to `fprintf Test…
xperiandri Jun 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .config/dotnet-tools.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,6 @@
"fake"
]
},
"paket": {
"version": "7.2.1",
"commands": [
"paket"
]
},
"fornax": {
"version": "0.13.1",
"commands": [
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

- Migrate from `Paket` to `Directory.Packages.props` #722 [@xperiandri]
- Migrate to .NET `9.0.201` and FCS `43.9.201` #722 [@xperiandri]
- Write test logs to test context output #722 [@xperiandri]

## [0.24.2] - 2024-02-29

- New rule EnsureTailCallDiagnosticsInRecursiveFunctions #673 #651 [@webwarrior-ws]
Expand Down
1 change: 1 addition & 0 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<Project ToolsVersion="15.0">
<PropertyGroup>
<DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<MSBuildTreatWarningsAsErrors>true</MSBuildTreatWarningsAsErrors>
<IsPackable>false</IsPackable>
Expand Down
30 changes: 30 additions & 0 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
<?xml version="1.0" encoding="utf-8"?>
<Project>
<PropertyGroup>
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
</PropertyGroup>
<ItemGroup>
<PackageVersion Include="Argu" Version="6.2.5" />
<PackageVersion Include="BenchmarkDotNet" Version="0.15.2" />
<PackageVersion Include="BenchmarkDotNet.Diagnostics.Windows" Version="0.15.2" />
<PackageVersion Include="FParsec" Version="1.1.1" />
<PackageVersion Include="FSharp.Compiler.Service" Version="43.9.201" />
<PackageVersion Include="FSharp.Control.Reactive" Version="6.1.2" />
<PackageVersion Include="FSharp.Core" Version="9.0.201" />
<PackageVersion Include="Ionide.ProjInfo.ProjectSystem" Version="0.70.2" />
<PackageVersion Include="Ionide.ProjInfo.FCS" Version="0.70.2" />
<PackageVersion Include="Ionide.ProjInfo" Version="0.70.2" />
<PackageVersion Include="Ionide.ProjInfo.Sln" Version="0.68.0" />
Copy link
Contributor

@Numpsy Numpsy Jul 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, ProjInfo 0.70 dropped Ionide.ProjInfo.Sln in favor of using theMicrosoft.VisualStudio.SolutionPersistence instead, so I don't know if this is used directly?
Querying because one of the reasons for the change was to get support for .slnx solutions, which could be useful here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suggestion. I've implemented that. It will come in another PR

<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />
<PackageVersion Include="Microsoft.Build" Version="17.14.8" />
<PackageVersion Include="Microsoft.Build.Locator" Version="1.9.1" />
<PackageVersion Include="Microsoft.Build.Framework" Version="17.14.8" />
<PackageVersion Include="Microsoft.Build.Tasks.Core" Version="17.14.8" />
<PackageVersion Include="Microsoft.Build.Utilities.Core" Version="17.14.8" />
<PackageVersion Include="Microsoft.SourceLink.GitHub" Version="8.0.0" />
<PackageVersion Include="Newtonsoft.Json" Version="13.0.3" />
<PackageVersion Include="NUnit" Version="3.14.0" />
<PackageVersion Include="NUnit3TestAdapter" Version="5.0.0" />
<PackageVersion Include="System.Reactive" Version="6.0.1" />
</ItemGroup>
</Project>
6 changes: 4 additions & 2 deletions FSharpLint.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 16
VisualStudioVersion = 16.0.30002.166
# Visual Studio Version 17
VisualStudioVersion = 17.14.36221.1
MinimumVisualStudioVersion = 15.0.26124.0
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src", "src", "{40C2798B-7078-4D4F-BD37-195240CB827B}"
EndProject
Expand All @@ -22,6 +22,8 @@ EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{270E691D-ECA1-4BC5-B851-C5431A64E9FA}"
ProjectSection(SolutionItems) = preProject
build.fsx = build.fsx
Directory.Build.props = Directory.Build.props
Directory.Packages.props = Directory.Packages.props
EndProjectSection
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "docs", "docs", "{E1E03FFE-30DF-4522-83DA-9089147B431E}"
Expand Down
3 changes: 1 addition & 2 deletions global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"sdk": {
Copy link
Preview

Copilot AI Jun 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sdk section in global.json is missing the required version property, which can prevent .NET from selecting the correct SDK. Re-add a "version": "<sdk-version>" entry.

Suggested change
"sdk": {
"sdk": {
"version": "7.0.100",

Copilot uses AI. Check for mistakes.

"version": "6.0.417"
,"rollForward": "minor"
"rollForward": "minor"
}
}
63 changes: 0 additions & 63 deletions paket.dependencies
View file
Open in desktop

This file was deleted.

Loading